Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents

Checklist

  •  User Stories Documented
  •  User Stories Reviewed
  •  Design Reviewed
  •  APIs reviewed
  •  Release priorities assigned
  •  Test cases reviewed
  •  Blog post

Introduction 

CDAP pipelines is composed of various CDAP plugins. 

CDAP pipeline is composed of various CDAP plugins. These plugins handle error situations in case of invalid inputs or configurations. While developing CDAP pipelines, pipeline developer can provide invalid plugin configurations. For example, the BigQuery sink plugin can have invalid temporary GCS file which does not match with an underlying BigQuery table. In such situations, providing clear error message is helpful to guide user in right direction. Wrangler provides interactive way for users to apply directives to the data. However, while applying these directives, user may run into error situations. For example, the input json file may be corrupted which can fail parse-as-json directive. In such error situations, user should be provided clear error message so that further actions can be taken.

Goals

There are four

Contextual error messages provides meaningful information to CDAP users which can help them move forward in error situations. However, sometimes error messages can be vague and without context which can lead to an unpleasant user experience. Providing meaningful error messages to the users is a challenge. In many error situations, for the same type of error, the error message format is different. This inconsistency can confuse the users. Having a central repository of errors would help developers reuse the same error messages as well as formulate error messages in a consistent way.

When user is encountered with an error situation, error message can point users to appropriate actions. Sometimes the remedy would require users to follow a certain steps. For example, in wrangler, when a deployed database driver does not contain the driver class, users would need to repackage the jar and redeploy the jar. In this case, having a catalog of errors would help users to quickly find the steps to follow to fix the underlying issue. One approach to solve this challenge is to surface error codes to users along with error messages. Error codes would help users search the catalog with an error code and find the remedial steps.

Goals

There are three goals which needs to be achieved to improve error handling:

  • Provide a guideline
  • on how an error message should be formulated that makes it easier for end user to interpret the error situation
  • Instrument plugins to return multiple error messages for validation endpoint
  • Add a framework to standardize error messages in wrangler and pipelineto write better error messages: General best practices on formulating a meaningful Error Message
  • Add a framework to prefix add error codes to user facing the error messages so that developers users can figure out the source of error message

Scope

Plugins

  • Plugin Validation (Has a separate design doc - this document focuses on design of error codes and standard error messages)
    • Provide a framework to collect multiple validation errors so that they can be highlighted by UI when validation endpoint is called.
    • Provide a framework to add new type of exception without replacing data pipeline artifacts
    • Instrument plugins so that all the invalid config and schema fields are reported to the user at once when a plugin is validated

Dataprep

  • Improve error messages in all Directives
    • Remove usages of object hashes in the error messages. It happens because of usage of toString() in error messages
    • Standardize error messages 
    • Apply error codes to user facing error messages

Pipeline

  • Standardize error messages
  • Apply error codes to user facing error messages

User Stories

  • As a CDAP pipeline developer, if a pipeline contains plugin configurations which are invalid, I will like it to fail early with appropriate error message.

  • As an ETL engineer, if I run into error situation while applying directives, I will like to see appropriate error message which clearly indicates the error.

  • Scenario 1: Error codes in Wrangler

    Scenario 2: Standard Error messages in Wrangler

    Scenario 3: Error codes in Pipeline

    Scenario 4: Standard Error messages in Pipeline

    Approach

    Impact on UI

    UI changes will be needed for invalid schema type errors returned from validation endpoint.

    Test Scenarios

    Test ID

    Test Description

    Expected Results

    Bug Fixes 

    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-14378

    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-15499

    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-15507

    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-15040

    • browse the catalog to figure out remedial steps.
    • Add a framework to standardized error messages and put them at central location for better visibility.

    Scenarios

    • Scenario 1: Errors in Wrangler

      • Scenario 1.1

    Alice wants to wrangle data using CDAP's Wrangler tool. As part of that, Alice wants to connect to Database Source using Wrangler Connection. While attempting to do that, Alice is seeing a cryptic error message while testing the connection that she does not know how to resolve just by looking at the error message. In order figure out cause of the issue and recommended action, Alice will like to browse error code catalog with the error code displayed along with the error message.

      • Scenario 1.2

    Alice is applying transformations to the data on the fly using CDAP's Wrangler tool. However, while applying transformations, Alice sees an error message that does not suggest recommended action to fix the issue. She wants to browse the error code catalog to figure out recommended actions to resolve the issue.

      • Scenario 1.3

    Alice wants to wrangle data using CDAP's Wrangler tool. While applying transformations to the connected source data on the fly, Alice tries to parse boolean column as csv. However, Alice observes that built-in directives to parse boolean data as csv and avro returns different error messages. Alice would like to see standard error message from both the directives when column type is incompatible.

      • Scenario 1.4

    Alice wants to wrangle data using CDAP's Wrangler tool. While connecting to the source Alice uses user name and password stored in secure store. However, the secure store keys are not resolved. Alice wants to look at the error code and share it with the CDAP developer to figure out the underlying root cause.

    • Scenario 2: Errors in Pipeline

      • Scenario 2.1

    Alice is a pipeline developer who has built a pipeline using CDAP data pipeline studio. While running the pipeline, it failed with no meaningful error message in logs.To debug this issue further, Alice wants to share error code from the logs with Bob, the data pipeline app developer to figure out what is the cause of the error.

      • Scenario 2.2

    As a data pipeline developer, Alice is trying to get schema from the database source. While attempting to do that from CDAP data pipeline studio, Alice sees an error message. In order to figure out the cause and action for the error message, Alice will like to search the error code in the error catalog.

      • Scenario 2.3

    As a data pipeline developer, Alice is trying to validate the pipeline. While attempting to validate it, Alice saw an error message that requires fixing the plugin property. Alice want to have an error code along with the error message so that she can search the probable cause on error catalog.

      • Scenario 2.4

    As a data pipeline developer, Alice is using secure macros in the pipeline, however, the secure macros are not resolved. Alice wants to use the error code and share it with CDAP developer to figure out the root cause.

    • Scenario 3: Errors in CDAP

      • Scenario 3.1

    As a CDAP user, Alice wants to upload a plugin to CDAP. However, Alice is not deploy a plugin and gets an error. Alice wants to use the error code to browse the catalog to figure out the cause and recommended action.

      • Scenario 3.2

    As a CDAP user, Alice wants to enable Wrangler to wrangle data. However, Wrangler service is not starting up.Alice wants to use the error code so that it can be shared with the support engineer for further debugging.

      • Scenario 3.3

    As a CDAP user, Alice wants to enable Wrangler to wrangle data. However, Wrangler service is not starting up.Alice wants to use the error code so that it can be shared with CDAP developer to figure out the root cause.

    Design Discussions


    Code Block
    /**
     * Represents error codes.
     */
    @Beta
    public enum ErrorCode {
      // 11 prefix for directive errors
      UNSUPPORTED_ENCODING_TYPE("WRA-111001"),
    
      // 12 prefix for handler errors
      DRIVER_CLASS_NOT_FOUND("WRA-121001"),
      INVALID_MACRO_ERROR("WRA-121102");
      .....
    
    
      // 13 prefix for storage
      ....
    
      private String code;
    
      ErrorCode(String code) {
        this.code = code;
      }
    
      /**
       * Returns the code for this error.
       */
      public String getCode() {
        return this.code;
      }
    }
    Code Block
    languagejava
    titleErrorInforProvider.java
    /**
     * Error information provider.
     */
    @Beta
    public interface ErrorInfoProvider {
    
      /**
       * Returns error code associated with the error.
       * NOTE: this interface returns special error code for backwards compatibility.
       */
      default ErrorCode getErrorCode() {
        return ErrorCode.UNDEFINED_CODE;
      }
    
      /**
       * Returns an array of arguments to formulate error messages.
       */
      default Object[] getErrorArgs() {
        return null;
      }
    }


    Look up in the exception vs highest level (Handler and Wrangler Transform)

    • should be done in the exception - What if for some reason resolution fails?
    Code Block
    languagejava
    titleDirectiveLoadException.java
    /**
     * Class description here.
     */
    public class DirectiveLoadException extends Exception implements ErrorInfoProvider {
      private static final MessageLookup LOOKUP = new MessageLookup();
      private ErrorCode errorCode;
      private Object[] errorArgs;
    
      ...
    
      public DirectiveLoadException(ErrorCode errorCode, Object... args) {
        super(LOOKUP.get(errorCode.name(), args));
        this.errorCode = errorCode;
        this.errorArgs = args;
      }
    
      @Override
      public ErrorCode getErrorCode() {
        return errorCode;
      }
    
      @Override
      public Object[] getErrorArgs() {
        return errorArgs;
      }
    }


    Impact on UI


    Test Scenarios

    Test ID

    Test Description

    Expected Results













    Bug Fixes 

    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-1559314378

      Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-
      14797
      15040
    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-1556315499

    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-1556015593

    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-1176714797

    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-15426

    • Jira Legacy
      serverCask Community Issue Tracker
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId45b48dee-c8d6-34f0-9990-e6367dc2fe4b
      keyCDAP-15581

    Releases

    Release 6.1.0

    Related Work

    Future work

    Add error code and standard error message capability to CDAP platform.